refactor(core): collection expressions for Analysis DTOs and core VMs#707
Merged
cct08311github merged 1 commit intodotnet10from Mar 20, 2026
Merged
Conversation
…dListVM Replace `new List<T>()` property initializers with `[]` collection expressions: - AnalysisQueryRequest: Dimensions, Measures, Filters - AnalysisQueryResponse: Columns, Rows - ServerSideGroupByStrategy: empty list returns - BasePagedListVM: Ids First batch — remaining files deferred to follow-up. Closes #700 (partial) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
new List<T>()property initializers with C# 12 collection expressions[].Files changed
AnalysisQueryRequest.cs— Dimensions, Measures, Filters (3 properties)AnalysisQueryResponse.cs— Columns, Rows (2 properties)ServerSideGroupByStrategy.cs— empty list returns (2 locations)BasePagedListVM.cs— Ids (1 property)Not changed (intentional)
[]doesn't support dictionariesvar— collection expressions need explicit target typeTest plan
Closes #700
🤖 Generated with Claude Code